drm_atomic_state_test.c 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409
  1. // SPDX-License-Identifier: GPL-2.0
  2. /*
  3. * Test cases for the drm_atomic_state helpers
  4. *
  5. * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
  6. */
  7. #include <drm/drm_atomic.h>
  8. #include <drm/drm_atomic_helper.h>
  9. #include <drm/drm_atomic_uapi.h>
  10. #include <drm/drm_kunit_helpers.h>
  11. #include <drm/drm_probe_helper.h>
  12. #define DRM_TEST_ENC_0 BIT(0)
  13. #define DRM_TEST_ENC_1 BIT(1)
  14. #define DRM_TEST_ENC_2 BIT(2)
  15. #define DRM_TEST_CONN_0 BIT(0)
  16. struct drm_clone_mode_test {
  17. const char *name;
  18. u32 encoder_mask;
  19. int expected_result;
  20. };
  21. static const struct drm_display_mode drm_atomic_test_mode = {
  22. DRM_MODE("1024x768", 0, 65000, 1024, 1048,
  23. 1184, 1344, 0, 768, 771, 777, 806, 0,
  24. DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC)
  25. };
  26. struct drm_atomic_test_priv {
  27. struct drm_device drm;
  28. struct drm_plane *plane;
  29. struct drm_crtc *crtc;
  30. struct drm_encoder encoders[3];
  31. struct drm_connector connectors[2];
  32. };
  33. static int modeset_counter;
  34. static void drm_test_encoder_mode_set(struct drm_encoder *encoder,
  35. struct drm_crtc_state *crtc_state,
  36. struct drm_connector_state *conn_state)
  37. {
  38. modeset_counter++;
  39. }
  40. static const struct drm_encoder_helper_funcs drm_atomic_test_encoder_funcs = {
  41. .atomic_mode_set = drm_test_encoder_mode_set,
  42. };
  43. static const struct drm_connector_funcs dummy_connector_funcs = {
  44. .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
  45. .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
  46. .reset = drm_atomic_helper_connector_reset,
  47. };
  48. static int drm_atomic_test_dummy_get_modes(struct drm_connector *connector)
  49. {
  50. return drm_connector_helper_get_modes_fixed(connector,
  51. &drm_atomic_test_mode);
  52. }
  53. static const struct drm_connector_helper_funcs dummy_connector_helper_funcs = {
  54. .get_modes = drm_atomic_test_dummy_get_modes,
  55. };
  56. static struct drm_atomic_test_priv *
  57. drm_atomic_test_init_drm_components(struct kunit *test, bool has_connectors)
  58. {
  59. struct drm_atomic_test_priv *priv;
  60. struct drm_encoder *enc;
  61. struct drm_connector *conn;
  62. struct drm_device *drm;
  63. struct device *dev;
  64. int ret;
  65. dev = drm_kunit_helper_alloc_device(test);
  66. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
  67. priv = drm_kunit_helper_alloc_drm_device(test, dev,
  68. struct drm_atomic_test_priv,
  69. drm,
  70. DRIVER_MODESET | DRIVER_ATOMIC);
  71. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
  72. test->priv = priv;
  73. drm = &priv->drm;
  74. priv->plane = drm_kunit_helper_create_primary_plane(test, drm,
  75. NULL,
  76. NULL,
  77. NULL, 0,
  78. NULL);
  79. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->plane);
  80. priv->crtc = drm_kunit_helper_create_crtc(test, drm,
  81. priv->plane, NULL,
  82. NULL,
  83. NULL);
  84. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->crtc);
  85. for (int i = 0; i < ARRAY_SIZE(priv->encoders); i++) {
  86. enc = &priv->encoders[i];
  87. ret = drmm_encoder_init(drm, enc, NULL,
  88. DRM_MODE_ENCODER_DSI, NULL);
  89. KUNIT_ASSERT_EQ(test, ret, 0);
  90. enc->possible_crtcs = drm_crtc_mask(priv->crtc);
  91. }
  92. priv->encoders[0].possible_clones = DRM_TEST_ENC_0 | DRM_TEST_ENC_1;
  93. priv->encoders[1].possible_clones = DRM_TEST_ENC_0 | DRM_TEST_ENC_1;
  94. priv->encoders[2].possible_clones = DRM_TEST_ENC_2;
  95. if (!has_connectors)
  96. goto done;
  97. BUILD_BUG_ON(ARRAY_SIZE(priv->connectors) > ARRAY_SIZE(priv->encoders));
  98. for (int i = 0; i < ARRAY_SIZE(priv->connectors); i++) {
  99. conn = &priv->connectors[i];
  100. ret = drmm_connector_init(drm, conn, &dummy_connector_funcs,
  101. DRM_MODE_CONNECTOR_DSI, NULL);
  102. KUNIT_ASSERT_EQ(test, ret, 0);
  103. drm_connector_helper_add(conn, &dummy_connector_helper_funcs);
  104. drm_encoder_helper_add(&priv->encoders[i],
  105. &drm_atomic_test_encoder_funcs);
  106. drm_connector_attach_encoder(conn, &priv->encoders[i]);
  107. }
  108. done:
  109. drm_mode_config_reset(drm);
  110. return priv;
  111. }
  112. static int set_up_atomic_state(struct kunit *test,
  113. struct drm_atomic_test_priv *priv,
  114. struct drm_connector *connector,
  115. struct drm_modeset_acquire_ctx *ctx)
  116. {
  117. struct drm_device *drm = &priv->drm;
  118. struct drm_crtc *crtc = priv->crtc;
  119. struct drm_atomic_state *state;
  120. struct drm_connector_state *conn_state;
  121. struct drm_crtc_state *crtc_state;
  122. int ret;
  123. state = drm_kunit_helper_atomic_state_alloc(test, drm, ctx);
  124. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
  125. if (connector) {
  126. conn_state = drm_atomic_get_connector_state(state, connector);
  127. if (IS_ERR(conn_state))
  128. return PTR_ERR(conn_state);
  129. ret = drm_atomic_set_crtc_for_connector(conn_state, crtc);
  130. if (ret)
  131. return ret;
  132. }
  133. crtc_state = drm_atomic_get_crtc_state(state, crtc);
  134. if (IS_ERR(crtc_state))
  135. return PTR_ERR(crtc_state);
  136. ret = drm_atomic_set_mode_for_crtc(crtc_state, &drm_atomic_test_mode);
  137. if (ret)
  138. return ret;
  139. crtc_state->enable = true;
  140. crtc_state->active = true;
  141. if (connector) {
  142. ret = drm_atomic_commit(state);
  143. if (ret)
  144. return ret;
  145. } else {
  146. // dummy connector mask
  147. crtc_state->connector_mask = DRM_TEST_CONN_0;
  148. }
  149. return 0;
  150. }
  151. /*
  152. * Test that the DRM encoder mode_set() is called when the atomic state
  153. * connectors are changed but the CRTC mode is not.
  154. */
  155. static void drm_test_check_connector_changed_modeset(struct kunit *test)
  156. {
  157. struct drm_atomic_test_priv *priv;
  158. struct drm_modeset_acquire_ctx ctx;
  159. struct drm_connector *old_conn, *new_conn;
  160. struct drm_atomic_state *state;
  161. struct drm_device *drm;
  162. struct drm_connector_state *new_conn_state, *old_conn_state;
  163. int ret, initial_modeset_count;
  164. priv = drm_atomic_test_init_drm_components(test, true);
  165. KUNIT_ASSERT_NOT_NULL(test, priv);
  166. drm = &priv->drm;
  167. old_conn = &priv->connectors[0];
  168. new_conn = &priv->connectors[1];
  169. drm_modeset_acquire_init(&ctx, 0);
  170. // first modeset to enable
  171. retry_set_up:
  172. ret = set_up_atomic_state(test, priv, old_conn, &ctx);
  173. if (ret == -EDEADLK) {
  174. ret = drm_modeset_backoff(&ctx);
  175. if (!ret)
  176. goto retry_set_up;
  177. }
  178. KUNIT_ASSERT_EQ(test, ret, 0);
  179. state = drm_kunit_helper_atomic_state_alloc(test, drm, &ctx);
  180. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
  181. new_conn_state = drm_atomic_get_connector_state(state, new_conn);
  182. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, new_conn_state);
  183. old_conn_state = drm_atomic_get_connector_state(state, old_conn);
  184. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, old_conn_state);
  185. ret = drm_atomic_set_crtc_for_connector(old_conn_state, NULL);
  186. KUNIT_EXPECT_EQ(test, ret, 0);
  187. ret = drm_atomic_set_crtc_for_connector(new_conn_state, priv->crtc);
  188. KUNIT_EXPECT_EQ(test, ret, 0);
  189. initial_modeset_count = modeset_counter;
  190. // modeset_disables is called as part of the atomic commit tail
  191. ret = drm_atomic_commit(state);
  192. KUNIT_ASSERT_EQ(test, ret, 0);
  193. KUNIT_ASSERT_EQ(test, modeset_counter, initial_modeset_count + 1);
  194. drm_modeset_drop_locks(&ctx);
  195. drm_modeset_acquire_fini(&ctx);
  196. }
  197. /*
  198. * Test that the drm_crtc_in_clone_mode() helper can detect if a given CRTC
  199. * state is in clone mode
  200. */
  201. static void drm_test_check_in_clone_mode(struct kunit *test)
  202. {
  203. bool ret;
  204. const struct drm_clone_mode_test *param = test->param_value;
  205. struct drm_crtc_state *crtc_state;
  206. crtc_state = kunit_kzalloc(test, sizeof(*crtc_state), GFP_KERNEL);
  207. KUNIT_ASSERT_NOT_NULL(test, crtc_state);
  208. crtc_state->encoder_mask = param->encoder_mask;
  209. ret = drm_crtc_in_clone_mode(crtc_state);
  210. KUNIT_ASSERT_EQ(test, ret, param->expected_result);
  211. }
  212. /*
  213. * Test that the atomic commit path will succeed for valid clones (or non-cloned
  214. * states) and fail for states where the cloned encoders are not possible_clones
  215. * of each other.
  216. */
  217. static void drm_test_check_valid_clones(struct kunit *test)
  218. {
  219. int ret;
  220. const struct drm_clone_mode_test *param = test->param_value;
  221. struct drm_atomic_test_priv *priv;
  222. struct drm_modeset_acquire_ctx ctx;
  223. struct drm_device *drm;
  224. struct drm_atomic_state *state;
  225. struct drm_crtc_state *crtc_state;
  226. priv = drm_atomic_test_init_drm_components(test, false);
  227. KUNIT_ASSERT_NOT_NULL(test, priv);
  228. drm = &priv->drm;
  229. drm_modeset_acquire_init(&ctx, 0);
  230. retry_set_up:
  231. ret = set_up_atomic_state(test, priv, NULL, &ctx);
  232. if (ret == -EDEADLK) {
  233. ret = drm_modeset_backoff(&ctx);
  234. if (!ret)
  235. goto retry_set_up;
  236. }
  237. KUNIT_ASSERT_EQ(test, ret, 0);
  238. state = drm_kunit_helper_atomic_state_alloc(test, drm, &ctx);
  239. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
  240. retry:
  241. crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
  242. if (PTR_ERR(crtc_state) == -EDEADLK) {
  243. drm_atomic_state_clear(state);
  244. ret = drm_modeset_backoff(&ctx);
  245. if (!ret)
  246. goto retry;
  247. }
  248. KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
  249. crtc_state->encoder_mask = param->encoder_mask;
  250. // force modeset
  251. crtc_state->mode_changed = true;
  252. ret = drm_atomic_helper_check_modeset(drm, state);
  253. if (ret == -EDEADLK) {
  254. drm_atomic_state_clear(state);
  255. ret = drm_modeset_backoff(&ctx);
  256. if (!ret)
  257. goto retry;
  258. }
  259. KUNIT_ASSERT_EQ(test, ret, param->expected_result);
  260. drm_modeset_drop_locks(&ctx);
  261. drm_modeset_acquire_fini(&ctx);
  262. }
  263. static void drm_check_in_clone_mode_desc(const struct drm_clone_mode_test *t,
  264. char *desc)
  265. {
  266. sprintf(desc, "%s", t->name);
  267. }
  268. static void drm_check_valid_clones_desc(const struct drm_clone_mode_test *t,
  269. char *desc)
  270. {
  271. sprintf(desc, "%s", t->name);
  272. }
  273. static const struct drm_clone_mode_test drm_clone_mode_tests[] = {
  274. {
  275. .name = "in_clone_mode",
  276. .encoder_mask = DRM_TEST_ENC_0 | DRM_TEST_ENC_1,
  277. .expected_result = true,
  278. },
  279. {
  280. .name = "not_in_clone_mode",
  281. .encoder_mask = DRM_TEST_ENC_0,
  282. .expected_result = false,
  283. },
  284. };
  285. static const struct drm_clone_mode_test drm_valid_clone_mode_tests[] = {
  286. {
  287. .name = "not_in_clone_mode",
  288. .encoder_mask = DRM_TEST_ENC_0,
  289. .expected_result = 0,
  290. },
  291. {
  292. .name = "valid_clone",
  293. .encoder_mask = DRM_TEST_ENC_0 | DRM_TEST_ENC_1,
  294. .expected_result = 0,
  295. },
  296. {
  297. .name = "invalid_clone",
  298. .encoder_mask = DRM_TEST_ENC_0 | DRM_TEST_ENC_2,
  299. .expected_result = -EINVAL,
  300. },
  301. };
  302. KUNIT_ARRAY_PARAM(drm_check_in_clone_mode, drm_clone_mode_tests,
  303. drm_check_in_clone_mode_desc);
  304. KUNIT_ARRAY_PARAM(drm_check_valid_clones, drm_valid_clone_mode_tests,
  305. drm_check_valid_clones_desc);
  306. static struct kunit_case drm_test_check_modeset_test[] = {
  307. KUNIT_CASE(drm_test_check_connector_changed_modeset),
  308. {}
  309. };
  310. static struct kunit_case drm_in_clone_mode_check_test[] = {
  311. KUNIT_CASE_PARAM(drm_test_check_in_clone_mode,
  312. drm_check_in_clone_mode_gen_params),
  313. KUNIT_CASE_PARAM(drm_test_check_valid_clones,
  314. drm_check_valid_clones_gen_params),
  315. {}
  316. };
  317. static struct kunit_suite drm_test_check_modeset_test_suite = {
  318. .name = "drm_validate_modeset",
  319. .test_cases = drm_test_check_modeset_test,
  320. };
  321. static struct kunit_suite drm_in_clone_mode_check_test_suite = {
  322. .name = "drm_validate_clone_mode",
  323. .test_cases = drm_in_clone_mode_check_test,
  324. };
  325. kunit_test_suites(&drm_in_clone_mode_check_test_suite,
  326. &drm_test_check_modeset_test_suite);
  327. MODULE_AUTHOR("Jessica Zhang <quic_jesszhan@quicinc.com");
  328. MODULE_DESCRIPTION("Test cases for the drm_atomic_helper functions");
  329. MODULE_LICENSE("GPL");