imx-lcdc.c 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. // SPDX-FileCopyrightText: 2020 Marian Cichy <M.Cichy@pengutronix.de>
  3. #include <drm/clients/drm_client_setup.h>
  4. #include <drm/drm_bridge.h>
  5. #include <drm/drm_bridge_connector.h>
  6. #include <drm/drm_damage_helper.h>
  7. #include <drm/drm_drv.h>
  8. #include <drm/drm_fbdev_dma.h>
  9. #include <drm/drm_fb_dma_helper.h>
  10. #include <drm/drm_fourcc.h>
  11. #include <drm/drm_framebuffer.h>
  12. #include <drm/drm_gem_atomic_helper.h>
  13. #include <drm/drm_gem_dma_helper.h>
  14. #include <drm/drm_gem_framebuffer_helper.h>
  15. #include <drm/drm_of.h>
  16. #include <drm/drm_print.h>
  17. #include <drm/drm_probe_helper.h>
  18. #include <drm/drm_simple_kms_helper.h>
  19. #include <drm/drm_vblank.h>
  20. #include <linux/bitfield.h>
  21. #include <linux/clk.h>
  22. #include <linux/dma-mapping.h>
  23. #include <linux/mod_devicetable.h>
  24. #include <linux/module.h>
  25. #include <linux/platform_device.h>
  26. #define IMX21LCDC_LSSAR 0x0000 /* LCDC Screen Start Address Register */
  27. #define IMX21LCDC_LSR 0x0004 /* LCDC Size Register */
  28. #define IMX21LCDC_LVPWR 0x0008 /* LCDC Virtual Page Width Register */
  29. #define IMX21LCDC_LCPR 0x000C /* LCDC Cursor Position Register */
  30. #define IMX21LCDC_LCWHB 0x0010 /* LCDC Cursor Width Height and Blink Register*/
  31. #define IMX21LCDC_LCCMR 0x0014 /* LCDC Color Cursor Mapping Register */
  32. #define IMX21LCDC_LPCR 0x0018 /* LCDC Panel Configuration Register */
  33. #define IMX21LCDC_LHCR 0x001C /* LCDC Horizontal Configuration Register */
  34. #define IMX21LCDC_LVCR 0x0020 /* LCDC Vertical Configuration Register */
  35. #define IMX21LCDC_LPOR 0x0024 /* LCDC Panning Offset Register */
  36. #define IMX21LCDC_LSCR 0x0028 /* LCDC Sharp Configuration Register */
  37. #define IMX21LCDC_LPCCR 0x002C /* LCDC PWM Contrast Control Register */
  38. #define IMX21LCDC_LDCR 0x0030 /* LCDC DMA Control Register */
  39. #define IMX21LCDC_LRMCR 0x0034 /* LCDC Refresh Mode Control Register */
  40. #define IMX21LCDC_LICR 0x0038 /* LCDC Interrupt Configuration Register */
  41. #define IMX21LCDC_LIER 0x003C /* LCDC Interrupt Enable Register */
  42. #define IMX21LCDC_LISR 0x0040 /* LCDC Interrupt Status Register */
  43. #define IMX21LCDC_LGWSAR 0x0050 /* LCDC Graphic Window Start Address Register */
  44. #define IMX21LCDC_LGWSR 0x0054 /* LCDC Graph Window Size Register */
  45. #define IMX21LCDC_LGWVPWR 0x0058 /* LCDC Graphic Window Virtual Page Width Register */
  46. #define IMX21LCDC_LGWPOR 0x005C /* LCDC Graphic Window Panning Offset Register */
  47. #define IMX21LCDC_LGWPR 0x0060 /* LCDC Graphic Window Position Register */
  48. #define IMX21LCDC_LGWCR 0x0064 /* LCDC Graphic Window Control Register */
  49. #define IMX21LCDC_LGWDCR 0x0068 /* LCDC Graphic Window DMA Control Register */
  50. #define IMX21LCDC_LAUSCR 0x0080 /* LCDC AUS Mode Control Register */
  51. #define IMX21LCDC_LAUSCCR 0x0084 /* LCDC AUS Mode Cursor Control Register */
  52. #define IMX21LCDC_BGLUT 0x0800 /* Background Lookup Table */
  53. #define IMX21LCDC_GWLUT 0x0C00 /* Graphic Window Lookup Table */
  54. #define IMX21LCDC_LCPR_CC0 BIT(30) /* Cursor Control Bit 0 */
  55. #define IMX21LCDC_LCPR_CC1 BIT(31) /* Cursor Control Bit 1 */
  56. /* Values HSYNC, VSYNC and Framesize Register */
  57. #define IMX21LCDC_LHCR_HWIDTH GENMASK(31, 26)
  58. #define IMX21LCDC_LHCR_HFPORCH GENMASK(15, 8) /* H_WAIT_1 in the i.MX25 Reference manual */
  59. #define IMX21LCDC_LHCR_HBPORCH GENMASK(7, 0) /* H_WAIT_2 in the i.MX25 Reference manual */
  60. #define IMX21LCDC_LVCR_VWIDTH GENMASK(31, 26)
  61. #define IMX21LCDC_LVCR_VFPORCH GENMASK(15, 8) /* V_WAIT_1 in the i.MX25 Reference manual */
  62. #define IMX21LCDC_LVCR_VBPORCH GENMASK(7, 0) /* V_WAIT_2 in the i.MX25 Reference manual */
  63. #define IMX21LCDC_LSR_XMAX GENMASK(25, 20)
  64. #define IMX21LCDC_LSR_YMAX GENMASK(9, 0)
  65. /* Values for LPCR Register */
  66. #define IMX21LCDC_LPCR_PCD GENMASK(5, 0)
  67. #define IMX21LCDC_LPCR_SHARP BIT(6)
  68. #define IMX21LCDC_LPCR_SCLKSEL BIT(7)
  69. #define IMX21LCDC_LPCR_ACD GENMASK(14, 8)
  70. #define IMX21LCDC_LPCR_ACDSEL BIT(15)
  71. #define IMX21LCDC_LPCR_REV_VS BIT(16)
  72. #define IMX21LCDC_LPCR_SWAP_SEL BIT(17)
  73. #define IMX21LCDC_LPCR_END_SEL BIT(18)
  74. #define IMX21LCDC_LPCR_SCLKIDLE BIT(19)
  75. #define IMX21LCDC_LPCR_OEPOL BIT(20)
  76. #define IMX21LCDC_LPCR_CLKPOL BIT(21)
  77. #define IMX21LCDC_LPCR_LPPOL BIT(22)
  78. #define IMX21LCDC_LPCR_FLMPOL BIT(23)
  79. #define IMX21LCDC_LPCR_PIXPOL BIT(24)
  80. #define IMX21LCDC_LPCR_BPIX GENMASK(27, 25)
  81. #define IMX21LCDC_LPCR_PBSIZ GENMASK(29, 28)
  82. #define IMX21LCDC_LPCR_COLOR BIT(30)
  83. #define IMX21LCDC_LPCR_TFT BIT(31)
  84. #define INTR_EOF BIT(1) /* VBLANK Interrupt Bit */
  85. #define BPP_RGB565 0x05
  86. #define BPP_XRGB8888 0x07
  87. #define LCDC_MIN_XRES 64
  88. #define LCDC_MIN_YRES 64
  89. #define LCDC_MAX_XRES 1024
  90. #define LCDC_MAX_YRES 1024
  91. struct imx_lcdc {
  92. struct drm_device drm;
  93. struct drm_simple_display_pipe pipe;
  94. struct drm_connector *connector;
  95. void __iomem *base;
  96. struct clk *clk_ipg;
  97. struct clk *clk_ahb;
  98. struct clk *clk_per;
  99. };
  100. static const u32 imx_lcdc_formats[] = {
  101. DRM_FORMAT_RGB565, DRM_FORMAT_XRGB8888,
  102. };
  103. static inline struct imx_lcdc *imx_lcdc_from_drmdev(struct drm_device *drm)
  104. {
  105. return container_of(drm, struct imx_lcdc, drm);
  106. }
  107. static unsigned int imx_lcdc_get_format(unsigned int drm_format)
  108. {
  109. switch (drm_format) {
  110. default:
  111. DRM_WARN("Format not supported - fallback to XRGB8888\n");
  112. fallthrough;
  113. case DRM_FORMAT_XRGB8888:
  114. return BPP_XRGB8888;
  115. case DRM_FORMAT_RGB565:
  116. return BPP_RGB565;
  117. }
  118. }
  119. static void imx_lcdc_update_hw_registers(struct drm_simple_display_pipe *pipe,
  120. struct drm_plane_state *old_state,
  121. bool mode_set)
  122. {
  123. struct drm_crtc *crtc = &pipe->crtc;
  124. struct drm_plane_state *new_state = pipe->plane.state;
  125. struct drm_framebuffer *fb = new_state->fb;
  126. struct imx_lcdc *lcdc = imx_lcdc_from_drmdev(pipe->crtc.dev);
  127. u32 lpcr, lvcr, lhcr;
  128. u32 framesize;
  129. dma_addr_t addr;
  130. addr = drm_fb_dma_get_gem_addr(fb, new_state, 0);
  131. /* The LSSAR register specifies the LCD screen start address (SSA). */
  132. writel(addr, lcdc->base + IMX21LCDC_LSSAR);
  133. if (!mode_set)
  134. return;
  135. /* Disable PER clock to make register write possible */
  136. if (old_state && old_state->crtc && old_state->crtc->enabled)
  137. clk_disable_unprepare(lcdc->clk_per);
  138. /* Framesize */
  139. framesize = FIELD_PREP(IMX21LCDC_LSR_XMAX, crtc->mode.hdisplay >> 4) |
  140. FIELD_PREP(IMX21LCDC_LSR_YMAX, crtc->mode.vdisplay);
  141. writel(framesize, lcdc->base + IMX21LCDC_LSR);
  142. /* HSYNC */
  143. lhcr = FIELD_PREP(IMX21LCDC_LHCR_HFPORCH, crtc->mode.hsync_start - crtc->mode.hdisplay - 1) |
  144. FIELD_PREP(IMX21LCDC_LHCR_HWIDTH, crtc->mode.hsync_end - crtc->mode.hsync_start - 1) |
  145. FIELD_PREP(IMX21LCDC_LHCR_HBPORCH, crtc->mode.htotal - crtc->mode.hsync_end - 3);
  146. writel(lhcr, lcdc->base + IMX21LCDC_LHCR);
  147. /* VSYNC */
  148. lvcr = FIELD_PREP(IMX21LCDC_LVCR_VFPORCH, crtc->mode.vsync_start - crtc->mode.vdisplay) |
  149. FIELD_PREP(IMX21LCDC_LVCR_VWIDTH, crtc->mode.vsync_end - crtc->mode.vsync_start) |
  150. FIELD_PREP(IMX21LCDC_LVCR_VBPORCH, crtc->mode.vtotal - crtc->mode.vsync_end);
  151. writel(lvcr, lcdc->base + IMX21LCDC_LVCR);
  152. lpcr = readl(lcdc->base + IMX21LCDC_LPCR);
  153. lpcr &= ~IMX21LCDC_LPCR_BPIX;
  154. lpcr |= FIELD_PREP(IMX21LCDC_LPCR_BPIX, imx_lcdc_get_format(fb->format->format));
  155. writel(lpcr, lcdc->base + IMX21LCDC_LPCR);
  156. /* Virtual Page Width */
  157. writel(new_state->fb->pitches[0] / 4, lcdc->base + IMX21LCDC_LVPWR);
  158. /* Enable PER clock */
  159. if (new_state->crtc->enabled)
  160. clk_prepare_enable(lcdc->clk_per);
  161. }
  162. static void imx_lcdc_pipe_enable(struct drm_simple_display_pipe *pipe,
  163. struct drm_crtc_state *crtc_state,
  164. struct drm_plane_state *plane_state)
  165. {
  166. int ret;
  167. int clk_div;
  168. int bpp;
  169. struct imx_lcdc *lcdc = imx_lcdc_from_drmdev(pipe->crtc.dev);
  170. struct drm_display_mode *mode = &pipe->crtc.mode;
  171. struct drm_display_info *disp_info = &lcdc->connector->display_info;
  172. const int hsync_pol = (mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : 1;
  173. const int vsync_pol = (mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : 1;
  174. const int data_enable_pol =
  175. (disp_info->bus_flags & DRM_BUS_FLAG_DE_HIGH) ? 0 : 1;
  176. const int clk_pol =
  177. (disp_info->bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE) ? 0 : 1;
  178. clk_div = DIV_ROUND_CLOSEST_ULL(clk_get_rate(lcdc->clk_per),
  179. mode->clock * 1000);
  180. bpp = imx_lcdc_get_format(plane_state->fb->format->format);
  181. writel(FIELD_PREP(IMX21LCDC_LPCR_PCD, clk_div - 1) |
  182. FIELD_PREP(IMX21LCDC_LPCR_LPPOL, hsync_pol) |
  183. FIELD_PREP(IMX21LCDC_LPCR_FLMPOL, vsync_pol) |
  184. FIELD_PREP(IMX21LCDC_LPCR_OEPOL, data_enable_pol) |
  185. FIELD_PREP(IMX21LCDC_LPCR_TFT, 1) |
  186. FIELD_PREP(IMX21LCDC_LPCR_COLOR, 1) |
  187. FIELD_PREP(IMX21LCDC_LPCR_PBSIZ, 3) |
  188. FIELD_PREP(IMX21LCDC_LPCR_BPIX, bpp) |
  189. FIELD_PREP(IMX21LCDC_LPCR_SCLKSEL, 1) |
  190. FIELD_PREP(IMX21LCDC_LPCR_PIXPOL, 0) |
  191. FIELD_PREP(IMX21LCDC_LPCR_CLKPOL, clk_pol),
  192. lcdc->base + IMX21LCDC_LPCR);
  193. /* 0px panning offset */
  194. writel(0x00000000, lcdc->base + IMX21LCDC_LPOR);
  195. /* disable hardware cursor */
  196. writel(readl(lcdc->base + IMX21LCDC_LCPR) & ~(IMX21LCDC_LCPR_CC0 | IMX21LCDC_LCPR_CC1),
  197. lcdc->base + IMX21LCDC_LCPR);
  198. ret = clk_prepare_enable(lcdc->clk_ipg);
  199. if (ret) {
  200. dev_err(pipe->crtc.dev->dev, "Cannot enable ipg clock: %pe\n", ERR_PTR(ret));
  201. return;
  202. }
  203. ret = clk_prepare_enable(lcdc->clk_ahb);
  204. if (ret) {
  205. dev_err(pipe->crtc.dev->dev, "Cannot enable ahb clock: %pe\n", ERR_PTR(ret));
  206. clk_disable_unprepare(lcdc->clk_ipg);
  207. return;
  208. }
  209. imx_lcdc_update_hw_registers(pipe, NULL, true);
  210. /* Enable VBLANK Interrupt */
  211. writel(INTR_EOF, lcdc->base + IMX21LCDC_LIER);
  212. }
  213. static void imx_lcdc_pipe_disable(struct drm_simple_display_pipe *pipe)
  214. {
  215. struct imx_lcdc *lcdc = imx_lcdc_from_drmdev(pipe->crtc.dev);
  216. struct drm_crtc *crtc = &lcdc->pipe.crtc;
  217. struct drm_pending_vblank_event *event;
  218. clk_disable_unprepare(lcdc->clk_ahb);
  219. clk_disable_unprepare(lcdc->clk_ipg);
  220. if (pipe->crtc.enabled)
  221. clk_disable_unprepare(lcdc->clk_per);
  222. spin_lock_irq(&lcdc->drm.event_lock);
  223. event = crtc->state->event;
  224. if (event) {
  225. crtc->state->event = NULL;
  226. drm_crtc_send_vblank_event(crtc, event);
  227. }
  228. spin_unlock_irq(&lcdc->drm.event_lock);
  229. /* Disable VBLANK Interrupt */
  230. writel(0, lcdc->base + IMX21LCDC_LIER);
  231. }
  232. static int imx_lcdc_pipe_check(struct drm_simple_display_pipe *pipe,
  233. struct drm_plane_state *plane_state,
  234. struct drm_crtc_state *crtc_state)
  235. {
  236. const struct drm_display_mode *mode = &crtc_state->mode;
  237. const struct drm_display_mode *old_mode = &pipe->crtc.state->mode;
  238. if (mode->hdisplay < LCDC_MIN_XRES || mode->hdisplay > LCDC_MAX_XRES ||
  239. mode->vdisplay < LCDC_MIN_YRES || mode->vdisplay > LCDC_MAX_YRES ||
  240. mode->hdisplay % 0x10) { /* must be multiple of 16 */
  241. drm_err(pipe->crtc.dev, "unsupported display mode (%u x %u)\n",
  242. mode->hdisplay, mode->vdisplay);
  243. return -EINVAL;
  244. }
  245. crtc_state->mode_changed =
  246. old_mode->hdisplay != mode->hdisplay ||
  247. old_mode->vdisplay != mode->vdisplay;
  248. return 0;
  249. }
  250. static void imx_lcdc_pipe_update(struct drm_simple_display_pipe *pipe,
  251. struct drm_plane_state *old_state)
  252. {
  253. struct drm_crtc *crtc = &pipe->crtc;
  254. struct drm_pending_vblank_event *event = crtc->state->event;
  255. struct drm_plane_state *new_state = pipe->plane.state;
  256. struct drm_framebuffer *fb = new_state->fb;
  257. struct drm_framebuffer *old_fb = old_state->fb;
  258. struct drm_crtc *old_crtc = old_state->crtc;
  259. bool mode_changed = false;
  260. if (old_fb && old_fb->format != fb->format)
  261. mode_changed = true;
  262. else if (old_crtc != crtc)
  263. mode_changed = true;
  264. imx_lcdc_update_hw_registers(pipe, old_state, mode_changed);
  265. if (event) {
  266. crtc->state->event = NULL;
  267. spin_lock_irq(&crtc->dev->event_lock);
  268. if (crtc->state->active && drm_crtc_vblank_get(crtc) == 0)
  269. drm_crtc_arm_vblank_event(crtc, event);
  270. else
  271. drm_crtc_send_vblank_event(crtc, event);
  272. spin_unlock_irq(&crtc->dev->event_lock);
  273. }
  274. }
  275. static const struct drm_simple_display_pipe_funcs imx_lcdc_pipe_funcs = {
  276. .enable = imx_lcdc_pipe_enable,
  277. .disable = imx_lcdc_pipe_disable,
  278. .check = imx_lcdc_pipe_check,
  279. .update = imx_lcdc_pipe_update,
  280. };
  281. static const struct drm_mode_config_funcs imx_lcdc_mode_config_funcs = {
  282. .fb_create = drm_gem_fb_create_with_dirty,
  283. .atomic_check = drm_atomic_helper_check,
  284. .atomic_commit = drm_atomic_helper_commit,
  285. };
  286. static const struct drm_mode_config_helper_funcs imx_lcdc_mode_config_helpers = {
  287. .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm,
  288. };
  289. DEFINE_DRM_GEM_DMA_FOPS(imx_lcdc_drm_fops);
  290. static struct drm_driver imx_lcdc_drm_driver = {
  291. .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
  292. .fops = &imx_lcdc_drm_fops,
  293. DRM_GEM_DMA_DRIVER_OPS_VMAP,
  294. DRM_FBDEV_DMA_DRIVER_OPS,
  295. .name = "imx-lcdc",
  296. .desc = "i.MX LCDC driver",
  297. };
  298. static const struct of_device_id imx_lcdc_of_dev_id[] = {
  299. {
  300. .compatible = "fsl,imx21-lcdc",
  301. },
  302. {
  303. .compatible = "fsl,imx25-lcdc",
  304. },
  305. { /* sentinel */ }
  306. };
  307. MODULE_DEVICE_TABLE(of, imx_lcdc_of_dev_id);
  308. static irqreturn_t imx_lcdc_irq_handler(int irq, void *arg)
  309. {
  310. struct imx_lcdc *lcdc = arg;
  311. struct drm_crtc *crtc = &lcdc->pipe.crtc;
  312. unsigned int status;
  313. status = readl(lcdc->base + IMX21LCDC_LISR);
  314. if (status & INTR_EOF) {
  315. drm_crtc_handle_vblank(crtc);
  316. return IRQ_HANDLED;
  317. }
  318. return IRQ_NONE;
  319. }
  320. static int imx_lcdc_probe(struct platform_device *pdev)
  321. {
  322. struct imx_lcdc *lcdc;
  323. struct drm_device *drm;
  324. struct drm_bridge *bridge;
  325. int irq;
  326. int ret;
  327. struct device *dev = &pdev->dev;
  328. lcdc = devm_drm_dev_alloc(dev, &imx_lcdc_drm_driver,
  329. struct imx_lcdc, drm);
  330. if (IS_ERR(lcdc))
  331. return PTR_ERR(lcdc);
  332. drm = &lcdc->drm;
  333. lcdc->base = devm_platform_ioremap_resource(pdev, 0);
  334. if (IS_ERR(lcdc->base))
  335. return dev_err_probe(dev, PTR_ERR(lcdc->base), "Cannot get IO memory\n");
  336. bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0);
  337. if (IS_ERR(bridge))
  338. return dev_err_probe(dev, PTR_ERR(bridge), "Failed to find bridge\n");
  339. /* Get Clocks */
  340. lcdc->clk_ipg = devm_clk_get(dev, "ipg");
  341. if (IS_ERR(lcdc->clk_ipg))
  342. return dev_err_probe(dev, PTR_ERR(lcdc->clk_ipg), "Failed to get %s clk\n", "ipg");
  343. lcdc->clk_ahb = devm_clk_get(dev, "ahb");
  344. if (IS_ERR(lcdc->clk_ahb))
  345. return dev_err_probe(dev, PTR_ERR(lcdc->clk_ahb), "Failed to get %s clk\n", "ahb");
  346. lcdc->clk_per = devm_clk_get(dev, "per");
  347. if (IS_ERR(lcdc->clk_per))
  348. return dev_err_probe(dev, PTR_ERR(lcdc->clk_per), "Failed to get %s clk\n", "per");
  349. ret = dma_set_mask_and_coherent(drm->dev, DMA_BIT_MASK(32));
  350. if (ret)
  351. return dev_err_probe(dev, ret, "Cannot set DMA Mask\n");
  352. /* Modeset init */
  353. ret = drmm_mode_config_init(drm);
  354. if (ret)
  355. return dev_err_probe(dev, ret, "Cannot initialize mode configuration structure\n");
  356. /* CRTC, Plane, Encoder */
  357. ret = drm_simple_display_pipe_init(drm, &lcdc->pipe,
  358. &imx_lcdc_pipe_funcs,
  359. imx_lcdc_formats,
  360. ARRAY_SIZE(imx_lcdc_formats), NULL, NULL);
  361. if (ret < 0)
  362. return dev_err_probe(drm->dev, ret, "Cannot setup simple display pipe\n");
  363. ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
  364. if (ret < 0)
  365. return dev_err_probe(drm->dev, ret, "Failed to initialize vblank\n");
  366. ret = drm_bridge_attach(&lcdc->pipe.encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
  367. if (ret)
  368. return dev_err_probe(drm->dev, ret, "Cannot attach bridge\n");
  369. lcdc->connector = drm_bridge_connector_init(drm, &lcdc->pipe.encoder);
  370. if (IS_ERR(lcdc->connector))
  371. return dev_err_probe(drm->dev, PTR_ERR(lcdc->connector), "Cannot init bridge connector\n");
  372. drm_connector_attach_encoder(lcdc->connector, &lcdc->pipe.encoder);
  373. /*
  374. * The LCDC controller does not have an enable bit. The
  375. * controller starts directly when the clocks are enabled.
  376. * If the clocks are enabled when the controller is not yet
  377. * programmed with proper register values (enabled at the
  378. * bootloader, for example) then it just goes into some undefined
  379. * state.
  380. * To avoid this issue, let's enable and disable LCDC IPG,
  381. * PER and AHB clock so that we force some kind of 'reset'
  382. * to the LCDC block.
  383. */
  384. ret = clk_prepare_enable(lcdc->clk_ipg);
  385. if (ret)
  386. return dev_err_probe(dev, ret, "Cannot enable ipg clock\n");
  387. clk_disable_unprepare(lcdc->clk_ipg);
  388. ret = clk_prepare_enable(lcdc->clk_per);
  389. if (ret)
  390. return dev_err_probe(dev, ret, "Cannot enable per clock\n");
  391. clk_disable_unprepare(lcdc->clk_per);
  392. ret = clk_prepare_enable(lcdc->clk_ahb);
  393. if (ret)
  394. return dev_err_probe(dev, ret, "Cannot enable ahb clock\n");
  395. clk_disable_unprepare(lcdc->clk_ahb);
  396. drm->mode_config.min_width = LCDC_MIN_XRES;
  397. drm->mode_config.max_width = LCDC_MAX_XRES;
  398. drm->mode_config.min_height = LCDC_MIN_YRES;
  399. drm->mode_config.max_height = LCDC_MAX_YRES;
  400. drm->mode_config.preferred_depth = 16;
  401. drm->mode_config.funcs = &imx_lcdc_mode_config_funcs;
  402. drm->mode_config.helper_private = &imx_lcdc_mode_config_helpers;
  403. drm_mode_config_reset(drm);
  404. irq = platform_get_irq(pdev, 0);
  405. if (irq < 0) {
  406. ret = irq;
  407. return ret;
  408. }
  409. ret = devm_request_irq(dev, irq, imx_lcdc_irq_handler, 0, "imx-lcdc", lcdc);
  410. if (ret < 0)
  411. return dev_err_probe(drm->dev, ret, "Failed to install IRQ handler\n");
  412. platform_set_drvdata(pdev, drm);
  413. ret = drm_dev_register(&lcdc->drm, 0);
  414. if (ret)
  415. return dev_err_probe(dev, ret, "Cannot register device\n");
  416. drm_client_setup(drm, NULL);
  417. return 0;
  418. }
  419. static void imx_lcdc_remove(struct platform_device *pdev)
  420. {
  421. struct drm_device *drm = platform_get_drvdata(pdev);
  422. drm_dev_unregister(drm);
  423. drm_atomic_helper_shutdown(drm);
  424. }
  425. static void imx_lcdc_shutdown(struct platform_device *pdev)
  426. {
  427. drm_atomic_helper_shutdown(platform_get_drvdata(pdev));
  428. }
  429. static struct platform_driver imx_lcdc_driver = {
  430. .driver = {
  431. .name = "imx-lcdc",
  432. .of_match_table = imx_lcdc_of_dev_id,
  433. },
  434. .probe = imx_lcdc_probe,
  435. .remove = imx_lcdc_remove,
  436. .shutdown = imx_lcdc_shutdown,
  437. };
  438. module_platform_driver(imx_lcdc_driver);
  439. MODULE_AUTHOR("Marian Cichy <M.Cichy@pengutronix.de>");
  440. MODULE_DESCRIPTION("Freescale i.MX LCDC driver");
  441. MODULE_LICENSE("GPL");